Hi Josef, There are (old) coccinelle warnings in tree: git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git master head: 233564d3f5bde271885f5b784b63cfe627bba0a5 commit: ec93ee7ac77b2e95934253823918c3c684c1a36c [9/11] Btrfs: barrier before waitqueue_active All coccinelle warnings: + fs/btrfs/delayed-inode.c:1013:1-11: second lock on line 1013 -- + fs/btrfs/volumes.c:2888:1-3: WARNING: PTR_RET can be used (patch attached) vim +1013 fs/btrfs/delayed-inode.c 1010 int ret = 0; 1011 1012 do_again: > 1013 mutex_lock(&node->mutex); 1014 curr = __btrfs_first_delayed_deletion_item(node); 1015 if (!curr) 1016 goto delete_fail; ... 1031 if (curr) > 1032 goto do_again; 1033 else 1034 goto delete_fail; --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu <wfg@xxxxxxxxxxxxxxx> Intel Corporation
Generated by: api/ptr_ret.cocci Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -2885,10 +2885,7 @@ int btrfs_resume_balance_async(struct bt } tsk = kthread_run(balance_kthread, fs_info, "btrfs-balance"); - if (IS_ERR(tsk)) - return PTR_ERR(tsk); - - return 0; + return PTR_RET(tsk); } int btrfs_recover_balance(struct btrfs_fs_info *fs_info)
