Re: [josef-btrfs:master 9/11] fs/btrfs/transaction.c:1118:6: warning: 'parent' may be used uninitialized in this function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2 Aug 2012 10:31:23 +0800, Fengguang Wu wrote:
> There are new compile warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git master
> head:   8e1163044779e90662e96887cdd692c1594146ad
> commit: dd817e81e81bbb83b63317b169d0e57a5d7ae0e1 [9/11] Btrfs: fix error path in create_pending_snapshot()
> config: x86_64-randconfig-h031 (attached as .config)
> 
> All error/warnings:
> 
> fs/btrfs/transaction.c: In function 'create_pending_snapshot':
> fs/btrfs/transaction.c:1118:6: warning: 'parent' may be used uninitialized in this function [-Wmaybe-uninitialized]
> fs/btrfs/transaction.c:1119:19: warning: 'rsv' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> vim +1118 fs/btrfs/transaction.c
>   1115		if (ret)
>   1116			goto abort_trans;
>   1117	fail:
>> 1118		dput(parent);
>   1119		trans->block_rsv = rsv;
>   1120	no_free_objectid:
>   1121		kfree(new_root_item);

The patch I sent before is based on the v3.5.0, not Chris's latest for-linus branch, so...

I will send new patches to fix it. Thanks for your report.

Miao

> 
> ---
> 0-DAY kernel build testing backend         Open Source Technology Centre
> Fengguang Wu <wfg@xxxxxxxxxxxxxxx>                     Intel Corporation
> 


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux