RE: drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for catching typo.
Plz push a patch with fix.

Thanks,
Venu


> -----Original Message-----
> From: Fengguang Wu [mailto:fengguang.wu@xxxxxxxxx]
> Sent: Saturday, July 28, 2012 6:05 PM
> To: Venu Byravarasu
> Cc: Samuel Ortiz; Axel Lin; kernel-janitors@xxxxxxxxxxxxxxx; LKML
> Subject: drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests
> 
> Hi Venu,
> 
> Is this coccinelle warning a trivial one, or indicates some copy&paste
> error? It's introduced by commit 3c33be06 ("mfd: Add support for
> TPS65090").
> 
> drivers/mfd/tps65090.c:239:5-30: duplicated argument to && or ||
> 
> vim +239 drivers/mfd/tps65090.c
>    236
>    237	static bool is_volatile_reg(struct device *dev, unsigned int reg)
>    238	{
>  > 239		if ((reg == TPS65090_INT_STS) || (reg == TPS65090_INT_STS))
>    240			return true;
>    241		else
>    242			return false;
> 
> ---
> 0-DAY kernel build testing backend         Open Source Technology Centre
> Fengguang Wu <wfg@xxxxxxxxxxxxxxx>                     Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux