Re: [patch 2/2 -next] LEDS: propagate error codes in blinkm_detect()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ack'ed.

Regards,
Jan-Simon
Am Donnerstag, 26. Juli 2012, 10:00:25 schrieb Dan Carpenter:
> Use the error codes from the lower levels instead of -ENODEV.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
> index ae6ad63..f7c3d7f 100644
> --- a/drivers/leds/leds-blinkm.c
> +++ b/drivers/leds/leds-blinkm.c
> @@ -617,11 +617,11 @@ static int blinkm_detect(struct i2c_client *client,
> struct i2c_board_info *info) /* Step 1: Read BlinkM address back  - 
> cmd_char 'a' */
>  	ret = blinkm_write(client, BLM_GET_ADDR, NULL);
>  	if (ret < 0)
> -		return -ENODEV;
> +		return ret;
>  	usleep_range(20000, 30000);	/* allow a small delay */
>  	ret = blinkm_read(client, BLM_GET_ADDR, tmpargs);
>  	if (ret < 0)
> -		return -ENODEV;
> +		return ret;
> 
>  	if (tmpargs[0] != 0x09) {
>  		dev_err(&client->dev, "enodev DEV ADDR = 0x%02X\n", tmpargs[0]);

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux