On Mon, 23 Jul 2012 17:57:26 -0700 Michel Lespinasse <walken@xxxxxxxxxx> wrote: > On Sun, Jul 22, 2012 at 11:50 PM, Fengguang Wu <fengguang.wu@xxxxxxxxx> wrote: > > lib/rbtree_test.c: In function 'rbtree_test_init': > > lib/rbtree_test.c:107:2: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'cycles_t' [-Wformat] > > lib/rbtree_test.c: In function 'check': > > lib/rbtree_test.c:76:4: warning: 'blacks' may be used uninitialized in this function [-Wuninitialized] > > Andrew added a cast for the format issue. > > Regarding the uninitialized 'blacks' value, gcc is actually wrong > about it (it will always be initialized on the first loop iteration), > but we should probably add = 0 on the variable declaration to make gcc > happy. We should use uninitialized_var() if we're going to do that. Because that avoids adding unneeded instructions and is self-documenting. I saw that warning but assumed that later gcc's didn't emit it. If that was wrong then yes, we should fix it. > Andrew, do you want an additional patch for it, or should I > send you a replacement patch (same as before + that fix) ? Incremental patches are preferred please. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
