On Fri, 20 Jul 2012 10:06:34 +0300 Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > We sometimes pass NULL pointers to free_tty_struct(). One example where > it can happen is in the error handling code in pty_common_install(). > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx> We probably shouldn't be passing NULLs there but making free_tty_struct(NULL) a no-op matches the kfree and other behaviours and is robust. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html