Re: [vfs:for-next 97/99] fs/ext3/dir.c:306:14: error: too few arguments to function 'generic_file_llseek_size'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 17, 2012 at 12:12:00PM -0500, Eric Sandeen wrote:
> On 7/16/12 11:45 AM, Al Viro wrote:
> > On Mon, Jul 16, 2012 at 10:44:03AM -0500, Eric Sandeen wrote:
> >> Thanks - 
> >>
> >> I had sent "[PATCH 3/3] ext3: pass custom EOF to generic_file_llseek_size()" which I think should have fixed this up, along with "vfs: allow custom EOF in generic_file_llseek code"
> >>
> >> And, it is in Al's tree:
> >>
> >> http://git.kernel.org/?p=linux/kernel/git/viro/vfs.git;a=commitdiff;h=1073e38331024417f5b0c1fcf7af59b92fb92689
> >>
> >> as is the commit to make ext4 happy:
> >>
> >> http://git.kernel.org/?p=linux/kernel/git/viro/vfs.git;a=commitdiff;h=ac5d776ddd7933c7aa9bb8fe2f9b3104dff659ca
> > 
> > Yes, but it still creates a bisect hazard, so I'm going to fix that sucker up, along with
> > the similar mess in quota series.  Will be in #for-next tomorrow.
> > 
> 
> Ok, sorry.  My first proposed patch 1/3 would have been ok in this respect (it made a new function) but Matthew Wilcox suggested I change the existing function.  And I took his advice.  ;)  Oh well.

*shrug*

Just needed to grep for other callers and make the trivial change in them,
in the same commit.  Anyway, it's fixed in today's #for-next.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux