On Sun, 8 Jul 2012, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > If list_for_each_entry, etc complete a traversal of the list, the iterator > variable ends up pointing to an address at an offset from the list head, > and not a meaningful structure. Thus this value should not be used after > the end of the iterator. The patch replaces s->name by al->name, which is > referenced nearby. > > This problem was found using Coccinelle (http://coccinelle.lip6.fr/). > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index cc4ed03..ef9bf01 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -5395,7 +5395,7 @@ static int __init slab_sysfs_init(void) > err = sysfs_slab_alias(al->s, al->name); > if (err) > printk(KERN_ERR "SLUB: Unable to add boot slab alias" > - " %s to sysfs\n", s->name); > + " %s to sysfs\n", al->name); > kfree(al); > } Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
