Static checkers complain about the impossible condition here. In 084681d14e ('printk: flush continuation lines immediately to console'), we changed msg->level from being a u16 to being an unsigned 3 bit bitfield. That means we can remove the code here to handle log levels which are in the tens or hundreds column. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> diff --git a/kernel/printk.c b/kernel/printk.c index 660ba72..3edc531 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -822,15 +822,10 @@ static size_t print_prefix(const struct log *msg, bool syslog, char *buf) size_t len = 0; if (syslog) { - if (buf) { + if (buf) len += sprintf(buf, "<%u>", msg->level); - } else { + else len += 3; - if (msg->level > 9) - len++; - if (msg->level > 99) - len++; - } } len += print_time(msg->ts_nsec, buf ? buf + len : NULL); -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html