On Wed, 27 Jun 2012 08:51:55 -0500 Robin Holt <holt@xxxxxxx> wrote: > The code here has a nested spin_lock_irqsave(). It's not needed since > IRQs are already disabled and it causes a problem because it means that > IRQs won't be enabled again at the end. The second call to > spin_lock_irqsave() will overwrite the value of irq_flags and we can't > restore the proper settings. Please find large crayon and write on forehead "when fixing a bug, be sure to describe the end-user impact of that bug". Then others will have a chance of deciding whether the fix should be backported. > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Robin Holt <holt@xxxxxxx> I'm wondering if there should have been a Reported-by:dan in there. He's like that. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
