On Wed, Jun 27, 2012 at 2:08 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On 64 bit systems the current code sets 32 bits of "seg" and leaves the > other 32 uninitialized. It doesn't matter since the variable is never > used. But it's still messy and we should fix it. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > Originally sent on Fri, 2 Mar 2012. > > diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c > index 4d39a9f..97825f1 100644 > --- a/drivers/scsi/megaraid.c > +++ b/drivers/scsi/megaraid.c > @@ -524,7 +524,7 @@ mega_build_cmd(adapter_t *adapter, Scsi_Cmnd *cmd, int *busy) > mega_passthru *pthru; > scb_t *scb; > mbox_t *mbox; > - long seg; > + u32 seg; > char islogical; > int max_ldrv_num; > int channel = 0; > @@ -858,7 +858,7 @@ mega_build_cmd(adapter_t *adapter, Scsi_Cmnd *cmd, int *busy) > > /* Calculate Scatter-Gather info */ > mbox->m_out.numsgelements = mega_build_sglist(adapter, scb, > - (u32 *)&mbox->m_out.xferaddr, (u32 *)&seg); > + (u32 *)&mbox->m_out.xferaddr, &seg); > > return scb; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ Acked-by: Adam Radford <aradford@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
