There was a double unlock introduced in 60ff461067 ("staging: comedi: usbduxsigma: use attach_usb() hook"). Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c index 28f41e9..015b0d0 100644 --- a/drivers/staging/comedi/drivers/usbduxsigma.c +++ b/drivers/staging/comedi/drivers/usbduxsigma.c @@ -2781,7 +2781,6 @@ static int usbduxsigma_attach(struct comedi_device *dev, if (index < 0) { dev_err(dev->class_dev, "usbduxsigma: error: attach failed, dev not connected to the usb bus.\n"); - up(&start_stop_sem); ret = -ENODEV; } else ret = usbduxsigma_attach_common(dev, &usbduxsub[index], -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html