On Sat, 2012-06-09 at 19:08 +0300, Dan Carpenter wrote: > The intent here was clearly to set result to true if the 0x40000000 flag > was set. But instead there was a | vs & typo and we always set result > to true. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > I do not have the hardware to test this. The original code is clearly > buggy, but what about if 0x40000000 is the wrong flag? Looks like it is the right flag, I've checked wiki.laptop.org/images/5/5c/88ALP01_Datasheet_July_2007.pdf and your patch looks correct. -- Best Regards, Artem Bityutskiy
Attachment:
signature.asc
Description: This is a digitally signed message part