On 6/14/12 11:34 AM, "Dan Carpenter" <dan.carpenter@xxxxxxxxxx> wrote:
>The adapter->npars[] array has QLCNIC_MAX_PCI_FUNC elements. We
>allocate it that way a few lines earlier in the function. So this test
>is off by one.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
>diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>index 33c3e46..212c121 100644
>--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>@@ -479,7 +479,7 @@ qlcnic_init_pci_info(struct qlcnic_adapter *adapter)
>
> for (i = 0; i < QLCNIC_MAX_PCI_FUNC; i++) {
> pfn = pci_info[i].id;
>- if (pfn > QLCNIC_MAX_PCI_FUNC) {
>+ if (pfn >= QLCNIC_MAX_PCI_FUNC) {
> ret = QL_STATUS_INVALID_PARAM;
> goto err_eswitch;
> }
Thanks for the patch.
Acked-by: Anirban Chakraborty <anirban.chakraborty@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
