On Sat, 2012-06-09 at 18:57 +0300, Dan Carpenter wrote: > CMD_SYNC is zero so the if (cmd->flags & CMD_SYNC) is never true. I > think it should be if (cmd->flags == CMD_SYNC). This enables a lockdep > assertion. Good catch, thanks. It should really be if (!(cmd->flags & CMD_ASYNC)) though I think as there could be other flags set which don't make it non-sync. I'll commit a fix on Monday unless you want to send a separate patch (which I'll then pick up on Monday :-) ) johannes -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
