Am 07.06.2012 11:59, schrieb Dan Carpenter:
> On Thu, Jun 07, 2012 at 11:47:30AM +0200, walter harms wrote:
>>
>>
>> Am 07.06.2012 10:22, schrieb Dan Carpenter:
>>> These need to be signed to handle negative error codes.
>>>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>>>
>>> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
>>> index 210d4ae..0a2f026 100644
>>> --- a/drivers/platform/x86/sony-laptop.c
>>> +++ b/drivers/platform/x86/sony-laptop.c
>>> @@ -2113,7 +2113,7 @@ static ssize_t sony_nc_thermal_mode_show(struct device *dev,
>>> struct device_attribute *attr, char *buffer)
>>> {
>>> ssize_t count = 0;
>>> - unsigned int mode = sony_nc_thermal_mode_get();
>>> + int mode = sony_nc_thermal_mode_get();
>>>
>>> if (mode < 0)
>>> return mode;
>>> @@ -2480,7 +2480,7 @@ static void sony_nc_backlight_ng_read_limits(int handle,
>>> props->maxlvl = 0xff;
>>>
>>> offset = sony_find_snc_handle(handle);
>>
>> sony_find_snc_handle() should return an int, did something change ?
>
> offset is a u64. It has to be 64 bit. I thought about changing it
> to s64, but decided to just cast it here instead.
>
> regards,
> dan carpenter
>
If it this function
http://lxr.free-electrons.com/source/drivers/platform/x86/sony-laptop.c?a=powerpc#L817
it just returns an index expected to be <0x10.
also offset was an int
http://lxr.free-electrons.com/source/drivers/platform/x86/sony-laptop.c?a=powerpc#L1563
it make we wonder why somebody made the change ...
never mind
re,
wh
>>
>>> - if (offset < 0)
>>> + if ((int)offset < 0)
>>> return;
>>>
>>> /* try to read the boundaries from ACPI tables, if we fail the above
>>
>>
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
