On Mon, May 28, 2012 at 06:54:51PM +0200, Emil Goode wrote: > This patch fixes the cleanup code of the bfin_adv7393_fb_probe > function. > > 1) The resources were not freed in the order that we allocated them > so we call dma_free_coherent() before it was allocated. > 2) The labels weren't in the right place which also meant that we > freed resources that weren't allocated. > 3) We should free gpio_free(P_IDENT(P_PPI0_FS3)) before returning. > 4) Lets change the label names into something more meaningful. > > Signed-off-by: Emil Goode <emilgoode@xxxxxxxxx> > --- Yep. Looks great. I see the goto free_ppi_pins; I look up a couple lines. I see that yeah, it makes sense to free the ppi_pins. I hit the '*' key in vim I see that the label does exactly what it says. Move on. Bing. Bang. Boom. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
