On Mon, May 28, 2012 at 04:40:19PM +0200, Emil Goode wrote: > This patch fixes the cleanup code of the bfin_adv7393_fb_probe > function by changing the order in which cleanup is performed > and by adding one label. > Could you list the actual bugs which were fixed: 1) The resources were not freed in the order that we allocated them so we call dma_free_coherent() before it was allocated. 2) The labels weren't in the right place which also meant that we freed resources that weren't allocated. 3) We should free gpio_free(P_IDENT(P_PPI0_FS3)) before returning. The new gpio_free() is more important than the added label. Since you're changing all these, you may as well fix the label names as well. The out_9 style labels suck. The right way is to give them meaningful labels instead of GW-BASIC style labels. Labels should be named after what happens when you arrive. Some people name them after the start of the journey but that's a mistake. It's just like the town of Chicago is still called Chicago even though you might goto Chicago starting from Boston. Like this: err_ppi: free_dma(CH_PPI); fb_dealloc_cmap(&fbdev->info.cmap); err_palette: kfree(fbdev->info.pseudo_palette); regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
