On Thu, Mar 22, 2012 at 09:30:56AM +0300, Dan Carpenter wrote: > If we hit an error here, then we should unlock and unreference obj > before returning. > This is still present in linux-next. regards, dan carpenter > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c > index 852642d..6de6130 100644 > --- a/drivers/gpu/drm/udl/udl_gem.c > +++ b/drivers/gpu/drm/udl/udl_gem.c > @@ -210,7 +210,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev, > > ret = udl_gem_get_pages(gobj, GFP_KERNEL); > if (ret) > - return ret; > + goto out; > if (!gobj->base.map_list.map) { > ret = drm_gem_create_mmap_offset(obj); > if (ret) -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html