Am 17.05.2012 09:09, schrieb Dan Carpenter: > drm_core_ioremap() initializes ->handle. We already know > "dev->agp_buffer_map" is a valid pointer. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c > index cb1ee4e..6eb507a 100644 > --- a/drivers/gpu/drm/savage/savage_bci.c > +++ b/drivers/gpu/drm/savage/savage_bci.c > @@ -735,7 +735,7 @@ static int savage_do_init_bci(struct drm_device * dev, drm_savage_init_t * init) > return -EINVAL; > } > drm_core_ioremap(dev->agp_buffer_map, dev); > - if (!dev->agp_buffer_map) { > + if (!dev->agp_buffer_map->handle) { > DRM_ERROR("failed to ioremap DMA buffer region!\n"); > savage_do_cleanup_bci(dev); > return -ENOMEM; ok, the interface asks for that type of error :) re, wh -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html