Re: [patch] brcm80211: remove an unneeded NULL check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/14/2012 10:57 PM, Dan Carpenter wrote:
> This code causes a static checker warning because "pi" gets dereferenced
> before it is checked.  The dereference is inside the write_phy_reg()
> function which is called from wlc_phy_write_txmacreg_nphy().
> 
> This code is only called from wlc_phy_init_nphy() and "pi" is a
> valid pointer so we can remove the check for NULL.

Acked-by: Arend van Spriel <arend@xxxxxxxxxxxx>

> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c
> index 812b6e3..d6380f3 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c
> @@ -14358,7 +14358,7 @@ void wlc_phy_nphy_tkip_rifs_war(struct brcms_phy *pi, u8 rifs)
>  
>  	wlc_phy_write_txmacreg_nphy(pi, holdoff, delay);
>  
> -	if (pi && pi->sh && (pi->sh->_rifs_phy != rifs))
> +	if (pi->sh && (pi->sh->_rifs_phy != rifs))
>  		pi->sh->_rifs_phy = rifs;
>  }
>  
> 


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux