Re: [PATCH] crc32.c: cleanup unused variables warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 08, 2012 at 10:36:54PM -0300, Thiago Rafael Becker wrote:
> Variables t4, t5, t6 and t7 are only used when CRC_LE_BITS != 32.


Looks ok.

1) This silences a gcc warning yes?  Put the warning into the commit
   message.
2) It needs a Signed-off-by line.
3) Resend it to the people from scripts/get_maintainer.pl.  CC lkml.
   The stuff in lib/ is so important and the more review it gets
   the better.  Even trivial patches benifit from the extra review.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux