Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > On Wed, May 02, 2012 at 07:13:37PM +0300, Tomas Melin wrote: >> -Simplified function logic by assuming that n_chan >1 if not <=1. Removes >> one level of indentation. >> -> readability improved and code fits into 80 chars >> - Code indentation fixes, corrected comments >> - Added braces to if() for readability >> > > Greg of course is the Boss-man and he already explained that this > needed to get broken up, but yeah I also wanted to say that as well. > The first patch should just pull the if (n_chan == 1) forward, > remove the else clause, and pull the indent level in. > > When I review this stuff I have a script called rename_rev.pl > (attached) and I `cat your_patch.txt | rename_rev.pl`. It removes > the indenting changes and only shows the logic changes. So the > solid block of changes becomes a two liner which takes 10 seconds > to review. The other changes to line breaks and comments and curly > parens are much simpler to review on their own. 10 seconds for > each. It's way way easier to review one liner changes than a > tangled block of changes. And I have to thank you for the script. thanks. -- Nikola -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
