On Wed, May 02, 2012 at 07:14:34PM +0300, Tomas Melin wrote:
> Various comments and code lines longer than 80 chars fixed in file adv_pci1710.c.
>
> Signed-off-by: Tomas Melin <tomas.melin@xxxxxx>
> ---
> drivers/staging/comedi/drivers/adv_pci1710.c | 27 ++++++++++++-------------
> 1 files changed, 13 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c
> index 8318c82..dd40fd3 100644
> --- a/drivers/staging/comedi/drivers/adv_pci1710.c
> +++ b/drivers/staging/comedi/drivers/adv_pci1710.c
> @@ -982,14 +982,13 @@ static int pci171x_ai_cmdtest(struct comedi_device *dev,
> #ifdef PCI171X_EXTDEBUG
> pci171x_cmdtest_out(1, cmd);
> #endif
> - DPRINTK
> - ("adv_pci1710 EDBG: BGN: pci171x_ai_cmdtest(...) err=%d ret=1\n",
> - err);
> + DPRINTK(
> + "adv_pci1710 EDBG: BGN: pci171x_ai_cmdtest(...) err=%d ret=1\n",
> + err);
Ick, no, that's not ok.
It seems checkpatch doesn't realize this is a string, and should be ok.
If anything the line should look like:
DPRINTK("adv_pci1710 EDBG: BGN: pci171x_ai_cmdtest(...) err=%d ret=1\n",
err);
Care to redo this?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
