Re: [patch 2/2] [SCSI] pmcraid: cpu_to_le32() => cpu_to_le64()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ping?

regards,
dan carpenter

On 12/16/11, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> The cpu_to_le32() truncates the address to 32 bits.  All the other
> places that set .address use cpu_to_le64().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> What about if dma_addr_t is 32 bits on a big endian system?  Can that
> happen?
>
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> index d6bc4e6..8a239ea 100644
> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -1242,7 +1242,7 @@ static struct pmcraid_cmd *pmcraid_init_hcam
>
>  	ioadl[0].flags |= IOADL_FLAGS_READ_LAST;
>  	ioadl[0].data_len = cpu_to_le32(rcb_size);
> -	ioadl[0].address = cpu_to_le32(dma);
> +	ioadl[0].address = cpu_to_le64(dma);
>
>  	cmd->cmd_done = cmd_done;
>  	return cmd;
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors"
> in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux