On 24/04/12 22:46, Joe Perches wrote: > On Thu, 2012-04-19 at 07:14 +0200, Julia Lawall wrote: >> I don't know thw impact of the ./. I use the options >> >> --nokeywords --nogit-fallback --subsystem --norolestats -f >> >> julia >> >> On Thu, 19 Apr 2012, Jingoo Han wrote: >> >>>> -----Original Message----- >>>> From: Ryan Mallon > [] >>>> Oddly, scripts/get_maintainer.pl on this file doesn't return me, even >>>> though, according to git blame, I am the author of 90% of the commits. >>>> Should I have an entry in the MAINTAINERS file, or is >>>> scripts/get_maintainer.pl not working properly? >>> >>> There are optional differences in using scripts/get_maintainer.pl. >>> If you use './' ahead of file path, you will see your name. >>> >>> Without './' ahead of 'drivers/video/ep93xx-fb.c': >>> ./scripts/get_maintainer.pl --file drivers/video/ep93xx-fb.c >>> Florian Tobias Schandinat <FlorianSchandinat@xxxxxx> (maintainer:FRAMEBUFFER LAYER) >>> linux-fbdev@xxxxxxxxxxxxxxx (open list:FRAMEBUFFER LAYER) >>> linux-kernel@xxxxxxxxxxxxxxx (open list) >>> >>> With './' ahead of 'drivers/video/ep93xx-fb.c': >>> ./scripts/get_maintainer.pl --file ./drivers/video/ep93xx-fb.c >>> Ryan Mallon <rmallon@xxxxxxxxx> (commit_signer:2/3=67%) >>> Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> (commit_signer:1/3=33%) >>> H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> (commit_signer:1/3=33%) >>> Jesper Juhl <jj@xxxxxxxxxxxxx> (commit_signer:1/3=33%) >>> Jiri Kosina <jkosina@xxxxxxx> (commit_signer:1/3=33%) >>> linux-kernel@xxxxxxxxxxxxxxx (open list) > > Prefixing "./" to the file path bypasses the normal > get_maintainers pattern check for file maintainership. > > Florian Schandinat and linux-fbdev are not returned > in the second lookup above. > > One of the patterns for FRAMEBUFFER is > F: drivers/video/ > which is a direct match for is ep93xx-fb.c file, > so --git is not used by default. > > Adding --git may be appropriate and it also returns > Ryan's name in this case. Hi Joe, Thanks for the info. > Nominally, as framebuffer maintainer, Florian > should also have "signed-off" on these commits, > but many subsystems don't actually have a > single path or person for patches and commits. > > This file came into the tree via Andrew Morton. > The original driver was written before Florian became the framebuffer maintainer. The subsystem had no real maintainer at the time, which is why it went via Andrew. > About maintainership for individual files: > > If anyone thinks they are the maintainer for > a particular file, generally they should submit > a patch to MAINTAINERS adding a section with > their name, maintainership level and an > appropriate file pattern. Hmm, perhaps author is a better term than maintainer here. Any patches should still go via the framebuffer maintainer, Florian, but it would be useful in many cases for the original and/or most regular commit author to also get Cc'ed since in many cases they will have a better understanding of the code, even if the aren't "maintaining" it. ~Ryan -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
