Re: [PATCH] drivers/block/cciss.c: correct size computation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/21/2012 09:08 AM, Julia Lawall wrote:
From: Julia Lawall<Julia.Lawall@xxxxxxx>

The size argument to remap_pci_mem should be the size of desired structure,
not the pointer to it.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

//<smpl>
@expression@
expression *x;
@@

x =
  <+...
-sizeof(x)
+sizeof(*x)
...+>
//</smpl>

Signed-off-by: Julia Lawall<Julia.Lawall@xxxxxxx>
Acked-by: Mike Miller <mike.miller@xxxxxx>

---
  drivers/block/cciss.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index b0f553b..9f50d7d 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -4209,7 +4209,7 @@ static int __devinit cciss_find_cfgtables(ctlr_info_t *h)
  	if (rc)
  		return rc;
  	h->cfgtable = remap_pci_mem(pci_resource_start(h->pdev,
-		cfg_base_addr_index) + cfg_offset, sizeof(h->cfgtable));
+		cfg_base_addr_index) + cfg_offset, sizeof(*h->cfgtable));
  	if (!h->cfgtable)
  		return -ENOMEM;
  	rc = write_driver_ver_to_cfgtable(h->cfgtable);


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux