Re: [patch] wireless: at76c50x: allocating too much data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Sat, 21 Apr 2012, Dan Carpenter wrote:

On Sat, Apr 21, 2012 at 03:51:44PM +0200, Julia Lawall wrote:
Looking for x = ... sizeof(x) ... I get 9 reports.  In most cases it
looks like sizeof(x) is coincidentally the same as the size that is
wanted.  Two cases that look like they could have some noticible
effect are:

arch/xtensa/platforms/iss/network.c, line 789
drivers/block/cciss.c, line 4211


Clever.  You'd need to restrict it to places where x was a  pointer.

Yes, I didn't put the whole thing:

@r expression@
expression *x;
position p;
@@

x@p = <+... sizeof(x) ...+>

julia

That's better than my check which was specific to kmalloc().  (So
uh...  I'm going to rewrite mine as well to be more generic.  :P)

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux