On Tue, 2012-04-17 at 09:29 +0300, Dan Carpenter wrote:
> target_fabric_configfs_init() never returns NULL, it only returns
> ERR_PTRs.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c
> index 37c6098..d605971 100644
> --- a/drivers/target/sbp/sbp_target.c
> +++ b/drivers/target/sbp/sbp_target.c
> @@ -2559,9 +2559,9 @@ static int sbp_register_configfs(void)
> int ret;
>
> fabric = target_fabric_configfs_init(THIS_MODULE, "sbp");
> - if (!fabric) {
> + if (IS_ERR(fabric)) {
> pr_err("target_fabric_configfs_init() failed\n");
> - return -ENOMEM;
> + return PTR_ERR(fabric);
> }
>
> fabric->tf_ops = sbp_ops;
> --
Applied to lio-core. Thanks DanC!
--nab
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
