On Mon, Apr 09, 2012 at 11:41:19AM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@xxxxxxxxx>
>
> kfree() checks for NULL before freeing the memory.
> Remove redundant NULL check.
> This is just a clean up and also looks good from performance point of view.
I doubt it has any impact on performance.
[snip]
> static void qlcnic_free_lb_filters_mem(struct qlcnic_adapter *adapter)
> {
> - if (adapter->fhash.fmax && adapter->fhash.fhead)
> - kfree(adapter->fhash.fhead);
> -
> + kfree(adapter->fhash.fhead);
This changes how the code works. That's very sloppy to not notice
that. If you did notice it, it should be justified in the
changelog. :(
> adapter->fhash.fhead = NULL;
> adapter->fhash.fmax = 0;
> }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
