On 29/03/12 03:38, Takashi Iwai wrote: > At Wed, 28 Mar 2012 09:57:02 +0300, > Dan Carpenter wrote: >> >> This function returns zero or -ENOMEM, but because it's type is u16, the >> -ENOMEM gets changed to 65524. None of the callers care, but lets fix >> it anyway as a cleanup. >> >> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Applied it now. Thanks. Hmm. I guess it is too late to NAK this change? I'd prefer changing the return value to HPI_ERROR_MEMORY_ALLOC and leaving the function signature alone. Any chance to make this change? -- Eliot -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
