Re: [patch] Input: wacom - check for allocation failure in probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for catch.

Reviewed-by: Chris Bagwell <chris@xxxxxxxxxxxxxx>

On Tue, Mar 27, 2012 at 3:15 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> We accidentally removed the check for NULL in 3aac0ef10b "Input: wacom -
> isolate input registration".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
> index 19ba586..0d26921 100644
> --- a/drivers/input/tablet/wacom_sys.c
> +++ b/drivers/input/tablet/wacom_sys.c
> @@ -1002,6 +1002,8 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i
>                return -EINVAL;
>
>        wacom = kzalloc(sizeof(struct wacom), GFP_KERNEL);
> +       if (!wacom)
> +               return -ENOMEM;
>
>        wacom_wac = &wacom->wacom_wac;
>        wacom_wac->features = *((struct wacom_features *)id->driver_info);
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux