On Fri, Mar 23, 2012 at 09:00:19PM +0530, santosh prasad nayak wrote: > Can you please explain whats the disadvantage of having 'unlikely()' here ? > I have seen it at several places in driver side. And I bet they are used wrong there. Again, unless you are in some very performance critical section of code, don't use unlikely(). The big thing is that it just is not needed at all. Don't try to be smarter than the compiler if you don't need it, _AND_ you haven't actually measured it. greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html