On Fri, Mar 23, 2012 at 3:21 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Fri, Mar 23, 2012 at 03:11:45PM +0530, santosh nayak wrote:
>> - dev_wds = kmalloc( sizeof( struct net_device ), GFP_KERNEL );
>> - memset( dev_wds, 0, sizeof( struct net_device ));
>> + dev_wds = kzalloc(sizeof(struct net_device), GFP_KERNEL);
>> + if (unlikely(!dev_wds)) {
>> + printk(KERN_ERR "%s: failed to alloc memory\n", __func__);
>
> Don't resend, but kmalloc() already prints out way more extensive
> and useful error messages than this. No need to print an error
> message yourself normally.
>
Do you mean in the following format ?
+ if (unlikely(!dev_wds)) {
+ DBG_LEAVE(DbgInfo);
+ return;
+ }
regards
Santosh
> regards,
> dan carpenter
>
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
