Yes. You are right. Caller is interpreting 0 in opposite way of normal sequence. Thats why I misunderstood it. In general, 0 means success and on error we return -ve. Here its opposite. regards Santosh On Sat, Mar 17, 2012 at 11:48 AM, David Miller <davem@xxxxxxxxxxxxx> wrote: > From: santosh nayak <santoshprasadnayak@xxxxxxxxx> > Date: Fri, 16 Mar 2012 18:40:13 +0530 > >> We have 3 callers: gigaset_probe(), gigaset_tty_open() and >> gigaset_probe(). Each caller tries to free allocated memory >> if lock fails. This is possible if we returns -EINTR. > > Look again at the callers. > > They interpret "0" as an error, so your patch would break the driver. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
