Re: [patch] samsung-laptop: cleanup return type: mode_t vs umode_t

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 15, 2012 at 8:10 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> This function returns a umode_t (unsigned short) instead of mode_t which
> is an unsigned int on some architectures.  Cleaning this up silences a
> compile warning:
>
> drivers/platform/x86/samsung-laptop.c:1108:2: warning: initialization
>        from incompatible pointer type [enabled by default]
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
> index 7d7109f..0550bc5 100644
> --- a/drivers/platform/x86/samsung-laptop.c
> +++ b/drivers/platform/x86/samsung-laptop.c
> @@ -1086,7 +1086,7 @@ static int __init samsung_backlight_init(struct samsung_laptop *samsung)
>        return 0;
>  }
>
> -static mode_t samsung_sysfs_is_visible(struct kobject *kobj,
> +static umode_t samsung_sysfs_is_visible(struct kobject *kobj,
>                                       struct attribute *attr, int idx)
>  {
>        struct device *dev = container_of(kobj, struct device, kobj);

Thanks for the patch.

Acked-by: Corentin Chary <corentincj@xxxxxxxxxx>

Matthew, could you grab that one too ?
Thanks,


-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux