On Sat, 2012-03-10 at 11:49 +0300, Dan Carpenter wrote: > The intent here was to enable both NETIF_MSG_DRV and NETIF_MSG_PROBE > messages, but in the original code only the NETIF_MSG_DRV bit was set. > > NETIF_MSG_DRV and NETIF_MSG_PROBE are bits 0 and 1, they are not > supposed to be used to do a shift. I think the confusion is because > the msg_enable can also be controlled through ethtool which passes a bit > number that is used to do a bit shift. [...] No, the ethtool interface also uses a mask. However netif_msg_init() is commonly used to initialise the msg_enable mask based on a module parameter that's a bit number. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
