On 03/07/2012 11:05 AM, Dan Carpenter wrote:
> This is supposed to be doing a shift before the comparison instead of
> just doing a bitwise AND directly. The current code means the start()
> just returns without doing anything.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
ACK.
It was introduced by this commit which forgot to change that location:
commit a808ac0c4a2c5d81ba38a2a76d4ddc1de40d1539
Author: Alan Cox <alan@xxxxxxxxxxxxxxx>
Date: Mon Nov 30 13:18:02 2009 +0000
tty: moxa: Locking clean up
> diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
> index d15a071..0174d2d 100644
> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
> @@ -1331,7 +1331,7 @@ static void moxa_start(struct tty_struct *tty)
> if (ch == NULL)
> return;
>
> - if (!(ch->statusflags & TXSTOPPED))
> + if (!test_bit(TXSTOPPED, &ch->statusflags))
> return;
>
> MoxaPortTxEnable(ch);
thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
