Re: [patch] KEYS: testing wrong bit for KEY_FLAG_REVOKED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> The test for "if (cred->request_key_auth->flags & KEY_FLAG_REVOKED) {"
> should actually be "if (test_bit(KEY_FLAG_REVOKED, &req_key->flags)) {".
> The current code actually checks for KEY_FLAG_DEAD.

Looks okay.

> The patch is really a one liner but I introduced a new variable so that
> I don't go over the 80 character limit.

Just split the arguments for test_bit() onto separate lines.

David
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux