Thanks Dan, David. Just one quick comment... pci_enable_sriov's 2nd input is declared as type int and we were using u32 instead (for a non negative 16bit value). With a quick check I noticed that other pci_enable_sriov callers do something similar and may need to be taken care too: driver | type used ----------+-------------- mlx4 | int chelsio | unsigned int igb | unsigned int igbxe | unsigned int emulex | u32 vxge | u32 Another option would have been to make all drivers use int to match pci_enable_sriov (pci_enable_sriov->sriov_enable checks against negative values). (BTW, why is pci_enable_sriov prototype using int?) Thanks /Chris > -----Original Message----- > From: David Miller [mailto:davem@xxxxxxxxxxxxx] > Sent: Thursday, March 01, 2012 2:24 PM > To: dan.carpenter@xxxxxxxxxx > Cc: Roopa Prabhu (roprabhu); Christian Benvenuti (benve); Neel Patel > (neepatel); Nishank Trivedi (nistrive); netdev@xxxxxxxxxxxxxxx; kernel- > janitors@xxxxxxxxxxxxxxx > Subject: Re: [patch] enic: fix an endian bug in enic_probe() > > From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Date: Thu, 1 Mar 2012 10:19:54 +0300 > > > "num_vfs" is a u32 but we only use the high 16 bits and the low > 16bits > > are left as zero. That isn't a problem for little endian systems but > it > > will break on big endian ones. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Applied. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
