[PATCH v2] Trace: Add comment to notify a warning caused by a gcc bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



GCC (version < 4.6) warns 'page2' is uninitialized, but this is helpful
to track a real potential bug, simply add comment to note this.

Signed-off-by: Zhengwang Ruan <ruan.zhengwang@xxxxxxxxx>
---
v2: Change fix to add a comment.
---
 kernel/trace/trace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index a3f1bc5..ef332e6 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3694,7 +3694,7 @@ tracing_mark_write(struct file *filp, const char __user *ubuf,
 	int nr_pages = 1;
 	ssize_t written;
 	void *page1;
-	void *page2;
+	void *page2;	/* if you get a warning here, upgrade your gcc to 4.6 */
 	int offset;
 	int size;
 	int len;
-- 
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux