On 2/29/2012 12:01 PM, Dan Carpenter wrote: > thermal_zone_device_register() never returns NULL, on error it returns > and ERR_PTR(). > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c > index 880bf28..7352cf8 100644 > --- a/drivers/thermal/spear_thermal.c > +++ b/drivers/thermal/spear_thermal.c > @@ -149,9 +149,9 @@ static int spear_thermal_probe(struct platform_device *pdev) > > spear_thermal = thermal_zone_device_register("spear_thermal", 0, > stdev, &ops, 0, 0, 0, 0); > - if (!spear_thermal) { > + if (IS_ERR(spear_thermal)) { > dev_err(&pdev->dev, "thermal zone device is NULL\n"); > - ret = -EINVAL; > + ret = PTR_ERR(spear_thermal); > goto disable_clk; > } > Thanks. Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxx> -- viresh -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html