On Sat, Feb 25, 2012 at 12:03:56PM +0800, Zhengwang Ruan wrote: > >> static int binder_debug_no_lock; > >> -module_param_named(proc_no_lock, binder_debug_no_lock, bool, S_IWUSR | S_IRUGO); > >> +module_param_named(proc_no_lock, binder_debug_no_lock, int, S_IWUSR | S_IRUGO); > > Instead of doing this, it would be better to change the line before > > and declare binder_debug_no_lock as a bool. > > > > Actually, I did change the type for binder_debug_no_lock as a bool until > I noticed binder_debug_no_lock is to be assigned value to int variables > in the following context. I think this change may be helpful to keep > consistence with the following context and reduce confusion from a view > to read code. > The code isn't confusing... But anyway, the change affects how the option is presented to the user, and it should be bool. > > Use the ./scripts/get_maintainer.pl to find where to resend this > > Is it a common tool for community, how could I get it? > It's inside the kernel source tree. regards, dan carpenter
Attachment:
signature.asc
Description: Digital signature
