Re: [alsa-devel] [patch] ALSA: hda/realtek - cleanup a condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Mon, 06 Feb 2012 09:06:11 +0100,
David Henningsson wrote:
> 
> On 02/06/2012 08:52 AM, Dan Carpenter wrote:
> > Sparse complains that "spec->multiout.dac_nids" is a pointer.
> >
> > sound/pci/hda/patch_realtek.c:2321:37: error: incompatible types for operation (>)
> > sound/pci/hda/patch_realtek.c:2321:37:    left side has type unsigned short const [usertype] *dac_nids
> > sound/pci/hda/patch_realtek.c:2321:37:    right side has type int
> >
> > I think the intent here was just to check if it was non-NULL, but please
> > double check.
> 
> It could also have meant to be "if (spec->multiout.num_dacs > 0)", but 
> either way, it seems very unlikely that the condition is false.

Yeah, I think so.  Looks like David can read my old mind better than
me through his crystal ball.

I'll fix it up.  Thanks.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux