From: Julia Lawall <Julia.Lawall@xxxxxxx> PTR_ERR should be called before its argument is cleared. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e,e1; constant c; @@ *e = c ... when != e = e1 when != &e when != true IS_ERR(e) *PTR_ERR(e) // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> Reported-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx> --- This patch probably only half way solves the problem with this code. It would seem that it should have a goto at the end, but I am not sure to where. v2: correct commit message. drivers/power/pda_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c index fd49689..16611c3 100644 --- a/drivers/power/pda_power.c +++ b/drivers/power/pda_power.c @@ -316,8 +316,8 @@ static int pda_power_probe(struct platform_device *pdev) ac_draw = regulator_get(dev, "ac_draw"); if (IS_ERR(ac_draw)) { dev_dbg(dev, "couldn't get ac_draw regulator\n"); - ac_draw = NULL; ret = PTR_ERR(ac_draw); + ac_draw = NULL; } #ifdef CONFIG_USB_OTG_UTILS -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
