> >You can skip checking 'iores', too. I also did that in the example, but > >a lot of people seem to miss it. > > I can try to do that, but it seems a little bit unintuitive. > Perhaps it would be easier for people to remember to put in error > handling code when they need it if they always have to do it? If I > remove it, there will be one call that has no test and then another > call a few lines later that does. I see your point. I would still like to get rid of the duplicated code (then it can't be forgotten as well). Maybe I should have named the function something alike devm_check_and_request_and_ioremap()? Then I could have also introduced a similar function for requesting irq. Will think about this a bit more. Thanks for updating your patch! -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
