Re: [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le mardi 17 janvier 2012 à 23:48 +0300, Dan Carpenter a écrit :
> kmemcheck complains that ->redirect_genid doesn't get initialized.
> Presumably it should be set to zero.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
> index 86f13c67..49ce5f4 100644
> --- a/net/ipv4/inetpeer.c
> +++ b/net/ipv4/inetpeer.c
> @@ -447,6 +447,7 @@ relookup:
>  		p->rate_last = 0;
>  		p->pmtu_expires = 0;
>  		p->pmtu_orig = 0;
> +		p->redirect_genid = 0;
>  		memset(&p->redirect_learned, 0, sizeof(p->redirect_learned));
>  
> 

We dont really care, since we force redirect_learned.a4 to be 0

Only place we care is in ip_rt_redirect() and its done properly there.

Lets shutup kmemcheck.

Acked-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>



--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux