Re: [patch] target: make one-bit bitfields unsigned

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2012-01-15 at 14:30 +0300, Dan Carpenter wrote:
> Signed bitfields are a problem because instead of being 1 or 0 like
> you'd expect they are 0 and -1.  It doesn't cause a problem in this case
> but sparse complains:
> 
> drivers/target/iscsi/iscsi_target_core.h:564:56: error: dubious one-bit
> signed bitfield
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/target/iscsi/iscsi_target_core.h b/drivers/target/iscsi/iscsi_target_core.h
> index f1a02da..ebf81fd 100644
> --- a/drivers/target/iscsi/iscsi_target_core.h
> +++ b/drivers/target/iscsi/iscsi_target_core.h
> @@ -561,8 +561,8 @@ struct iscsi_conn {
>  	struct hash_desc	conn_tx_hash;
>  	/* Used for scheduling TX and RX connection kthreads */
>  	cpumask_var_t		conn_cpumask;
> -	int			conn_rx_reset_cpumask:1;
> -	int			conn_tx_reset_cpumask:1;
> +	unsigned int		conn_rx_reset_cpumask:1;
> +	unsigned int		conn_tx_reset_cpumask:1;
>  	/* list_head of struct iscsi_cmd for this connection */
>  	struct list_head	conn_cmd_list;
>  	struct list_head	immed_queue_list;
> --

Applied to lio-core.  Thanks Dan!

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux