On Wed, 2012-01-11 at 18:55 +0100, Szymon Janc wrote: > > > #define QUICKSTART_PF_DRIVER_NAME "quickstart" > > > #define QUICKSTART_PF_DEVICE_NAME "quickstart" > > > > > > +#define QS_INFO(fmt, arg...) printk(KERN_INFO "quickstart: " fmt "\n", > > > ##arg) +#define QS_ERR(fmt, arg...) printk(KERN_ERR "quickstart: " fmt > > > "\n", ##arg) + > > > > No. Don't do this. You can do same thing with pr_err() so you > > don't need to create your own macros. Just add this to the front: > > > > #define pr_fmt(fmt) "quickstart: " fmt > > > > We already have a million standard ways of printing stuff, we don't > > need a million and two. > > Ok, and thanks for review! I'll send V2 shortly. Before you send V2, this is better as: #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
