On Tue, 2011-12-27 at 15:01 +0100, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > Reimplement a call to devm_request_mem_region followed by a call to ioremap > or ioremap_nocache by a call to devm_request_and_ioremap. > > The semantic patch that makes this transformation is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @nm@ > expression myname; > identifier i; > @@ > > struct platform_driver i = { .driver = { .name = myname } }; > > @@ > expression dev,res,size; > expression nm.myname; > @@ > > -if (!devm_request_mem_region(dev, res->start, size, > - \(res->name\|dev_name(dev)\|myname\))) { > - ... > - return ...; > -} > ... when != res->start > ( > -devm_ioremap(dev,res->start,size) > +devm_request_and_ioremap(dev,res) > | > -devm_ioremap_nocache(dev,res->start,size) > +devm_request_and_ioremap(dev,res) > ) > ... when any > when != res->start > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> Pushed to l2-mtd-2.6.git, thanks! I think this semantic patch is also useful and deserves to be added to scripts/coccinelle. In general, it would be great if you sumbitted useful spatches there for inclusion. -- Best Regards, Artem Bityutskiy
Attachment:
signature.asc
Description: This is a digitally signed message part
